Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This library does not conform to RN standards #325

Open
billnbell opened this issue Jun 15, 2023 · 6 comments
Open

This library does not conform to RN standards #325

billnbell opened this issue Jun 15, 2023 · 6 comments

Comments

@billnbell
Copy link

There are several real issues with this library.

  1. First the RN standard is to create a package that loads in Android and IOS - not doing it in a CLI command
  2. The RN 70.* new architecture and removing the RN Bridging mode needs to happen

Deploying to NPM so that we can yarn add react-native-force and then yarn ios / yarn android should be ALL you ever need.

Can we get some help forking this and fixing it to conform to how everyone else does it?

@wmathurin
Copy link
Contributor

We have it in our backlog to revisit how we do our react native templates and bridging, but no time set yet for getting to that work.

@JFoxUK
Copy link

JFoxUK commented Jun 20, 2023

This is an absolute must and is one of the reasons why we stay clear from using the Salesforce SDK most of the time.

@billnbell
Copy link
Author

Yeah if you just look at this repo that is a good example of how to do it.

I converted this to work with RN Bridging and this compiles without doing any injection into Xcode or Android Studio files.

https://github.com/billnbell/react-native-sunshine-conversations

  1. Create a pod spec react-native-smooch.podspec
  2. Create build.gradle with dependencies https://github.com/billnbell/react-native-sunshine-conversations/blob/master/android/build.gradle

@billnbell
Copy link
Author

Or just copy your competitor's setup. https://github.com/FormidableLabs/react-native-app-auth

@JFoxUK
Copy link

JFoxUK commented Jul 26, 2023

@wmathurin @bbirman is this on the roadmap?

@hmkcfs
Copy link

hmkcfs commented Aug 17, 2024

@wmathurin @bbirman , React Native team officially suggested to use frameworks like exp. When will you guys support Expo for Salesforce mobile SDK

https://reactnative.dev/blog/2024/06/25/use-a-framework-to-build-react-native-apps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants