Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.2.0] oauth.authenticate no longer resolves after login on Android #247

Open
mjmasn opened this issue Oct 18, 2021 · 11 comments
Open

[9.2.0] oauth.authenticate no longer resolves after login on Android #247

mjmasn opened this issue Oct 18, 2021 · 11 comments
Labels

Comments

@mjmasn
Copy link
Contributor

mjmasn commented Oct 18, 2021

This is a critical issue.

In our MainActivity.java we're using:

	public boolean shouldAuthenticate() {
		return false;
	}

(and the equivalent on iOS)

When a user clicks login on our welcome screen, we call oauth.getAuthCredentials then if that fails we call oauth.authenticate. Since upgrading from 8.3.0 to 9.2.0 this authenticate call no longer resolves at all on Android.

I've whipped up a quick reproduction repo here: https://github.com/mjmasn/AuthIssue

The repo above contains a fresh app created with forcereact with the typescript template with the following changes:

  • Returning false from shouldAuthenticate() in MainActivity.java
  • Replaced app.tsx with a component that renders 3 buttons that call the oauth functions and log to the console
  • Gradle 7.3 pre-release so I can build with Java 17 I reverted this and installed Java 11 to rule out any issues here
@mjmasn
Copy link
Contributor Author

mjmasn commented Oct 18, 2021

I've done some further investigation - looks like the issue was introduced in this commit forcedotcom/SalesforceMobileSDK-Android@4bb9cca

@wmathurin wmathurin added the bug label Oct 18, 2021
@bhariharan
Copy link
Contributor

We will take a look, thank you for reporting!

@kchelvan
Copy link

kchelvan commented Dec 5, 2021

Encountering this issue as well. Following this thread +1

@AnuragTiwari1
Copy link

AnuragTiwari1 commented Dec 8, 2021

Hi @bhariharan @wmathurin @mjmasn did you find any workaround for this, i am facing this one as well. I am currently using v9.2.0

@kchelvan
Copy link

@AnuragTiwari1 I managed to solve this temporarily by reverting the change made on the commit that @mjmasn mentioned.

@mjmasn
Copy link
Contributor Author

mjmasn commented Jan 14, 2022

Any update on this @bhariharan?

@gkotula
Copy link

gkotula commented Mar 7, 2022

Hi all, we are still aware of this issue and it is prioritized on the roadmap. This issue requires a careful fix which is why it is taking so long. Thank you for your patience!

@Ruslan-Mz
Copy link

Experiencing same issue in v10... workaround still helps. Thank you very much!

@Chandrakala-B
Copy link

Any update on this??

@vinod1988
Copy link

vinod1988 commented Jan 2, 2024

Any update on this??. We are facing the same issue at version 11.1.0 of react native sdk

@ayushcloudanalogy
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

10 participants