Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MobileSDK.oauth.authenticate() should always either Resolve or Reject #175

Open
jpmonette opened this issue May 7, 2020 · 2 comments
Open
Labels

Comments

@jpmonette
Copy link
Contributor

Executing oauth.authenticate() will not resolve or reject if the end-user clicks the Back button in the OAuth flow.

const launchOAuth = async () => {
  try {
    const token = await SDK.oauth.authenticate(); // execution will never go pass this point if end-user clicks Back
    console.log(token);
  } catch (e) {
    console.log(e);
  }
};

Expected

When a user clicks on the Back button, promise should resolve with no token, or throw an error.

Actual

Code hangs at line const token = await SDK.oauth.authenticate();, never continuing execution flow or throwing an error.

@wmathurin
Copy link
Contributor

From your description, I'm guessing it's an Android issue?

@wmathurin wmathurin added the bug label May 13, 2020
@jpmonette
Copy link
Contributor Author

@wmathurin This has been tested on iOS. I don't know about Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants