Skip to content
This repository has been archived by the owner on Mar 10, 2018. It is now read-only.

Query with has_available_redemptions? #15

Open
sammdec opened this issue Jan 3, 2016 · 0 comments
Open

Query with has_available_redemptions? #15

sammdec opened this issue Jan 3, 2016 · 0 comments

Comments

@sammdec
Copy link

sammdec commented Jan 3, 2016

Hi there, more of a query than an issue, I have found looking through your code really really helpful and have learnt alot from it, so thank you very much for that!

I noticed one method though and I don't see how it works and was hoping you might be able to shed light on it.

https://github.com/fnando/coupons/blob/master/lib/coupons/models/coupon.rb#L65
The method named has_available_redemptions?, I assume should return true if there is no limit set(0) but from this code it will return false?

Therefore would that not make redeemable? false as well

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant