Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library package #73

Closed
fmang opened this issue Mar 3, 2018 · 2 comments
Closed

Library package #73

fmang opened this issue Mar 3, 2018 · 2 comments
Milestone

Comments

@fmang
Copy link
Owner

fmang commented Mar 3, 2018

For the beatmap indexer (#35), and skin management, there's probably going to be a ~/.oshu directory popping out soon. What should we call it?

This directory will certainly contain skins and beatmaps.

I think it makes sense to group skin discovery and beatmaps discovery in the same directory, since in both case the job is to scan the filesystem and find files or directories. Not only the user's home directory but also the oshu! installation directory.

The module would define namespaces like oshu::library::beatmaps and oshu::library::skins, and depend on the beatmap and audio modules I guess.

Related to #67.

@fmang fmang changed the title Library module Library package Mar 3, 2018
@lanodan
Copy link
Contributor

lanodan commented Mar 3, 2018

I think the directory should try to follow XDG specifications, it doesn’t really hurt anyway and I think it could allow neat things (like data dir in removable storage).
So beatmaps, skins … in ${XDG_DATA_DIR:-$HOME/.local/share} and configuration in ${XDG_CONF_DIR:-$HOME/.config}.

@fmang fmang added this to the 2.0 milestone Mar 5, 2018
@fmang
Copy link
Owner Author

fmang commented Mar 15, 2018

The module is here, with the beatmaps sub-module. The skins sub-module will probably be added to library along with #67.

The XDG_DATA_DIR is already used for the oshu! installation, but I don't think it's a good idea to have the user wander about in .local to look for beatmaps. ~/.oshu sounds like a more natural place to extract all your beatmaps, even though it contributes to the home directory pollution :/

@fmang fmang closed this as completed Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants