[BUG] hostname v.s. nodeName in logging link template #6086
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
help wanted
Extra attention is needed
Describe the bug
It's about the
{{ .hostname }}
parameter to generate a templated logging link.As per the doc (https://docs.flyte.org/en/latest/user_guide/productionizing/configuring_logging_links_in_the_ui.html), this parameter is
I interpreted it as the specific node's hostname where the pod has been scheduled to run, i.e., the pod's
spec.nodeName
.However, it's currently set to the pod's
spec.hostname
, which is used to override the hostname the pod uses internally within its own network namespace:https://github.com/flyteorg/flyte/blob/v1.13.3/flyteplugins/go/tasks/logs/logging_utils.go#L57
In practice, the node name is likely more useful for generating a logging link than the
spec.hostname
(actually, we're using it to generate a Datadog dashboard link and need this to query the host metrics).Expected behavior
I expect
{{ .hostname }}
parameter to be the hostname where the pod has been scheduled to run (pod.Spec.NodeName
) instead ofpod.Spec.Hostname
.If we believe it makes sense to have
{{ .hostname }}
parameter presentingpod.Spec.Hostname
. It's better to update the doc mentioned above and also add a new parameter e.g.{{ .nodeName }}
.Thanks!
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: