Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeName template var and update doc #6088

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

ketian-indeed
Copy link
Contributor

@ketian-indeed ketian-indeed commented Dec 6, 2024

Tracking issue

Closes #6086

Why are the changes needed?

See #6086 for more details.

What changes were proposed in this pull request?

  1. added a new template variable {{ .nodeName }} that will return the pod's spec.nodeName;
  2. also updated the doc accordingly.

How was this patch tested?

Unit tests added.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#4939

Docs link

Copy link

welcome bot commented Dec 6, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@ketian-indeed
Copy link
Contributor Author

A friendly bump @ppiegaze @eapolinario 🙇

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.01%. Comparing base (7aeaa26) to head (e83ad6f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6088   +/-   ##
=======================================
  Coverage   37.00%   37.01%           
=======================================
  Files        1318     1318           
  Lines      132516   132519    +3     
=======================================
+ Hits        49037    49046    +9     
+ Misses      79235    79229    -6     
  Partials     4244     4244           
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.23% <ø> (+0.02%) ⬆️
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (ø)
unittests-flyteidl 7.23% <ø> (ø)
unittests-flyteplugins 53.86% <100.00%> (+<0.01%) ⬆️
unittests-flytepropeller 42.59% <ø> (ø)
unittests-flytestdlib 55.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario enabled auto-merge (squash) December 26, 2024 22:56
@eapolinario eapolinario merged commit bf38993 into flyteorg:master Dec 26, 2024
51 of 52 checks passed
Copy link

welcome bot commented Dec 26, 2024

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] hostname v.s. nodeName in logging link template
3 participants