Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[copilot] rename sidecar to uploader #5995

Closed
2 tasks done
wayner0628 opened this issue Nov 12, 2024 · 6 comments
Closed
2 tasks done

[copilot] rename sidecar to uploader #5995

wayner0628 opened this issue Nov 12, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request housekeeping Issues that help maintain flyte and keep it tech-debt free

Comments

@wayner0628
Copy link
Contributor

Motivation: Why do you think this is important?

The current naming of the upload container in Copilot as sidecar can be confusing, especially since we also have a dedicated downloader container. Given that this container primarily handles upload tasks, renaming it to something more descriptive would improve readability and understanding of its role.

Goal: What should the final outcome look like, ideally?

The final outcome should involve renaming all instances of sidecar related to the upload container—both in the UI and codebase—to uploader.

Describe alternatives you've considered

NA

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@wayner0628 wayner0628 added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Nov 12, 2024
@wayner0628
Copy link
Contributor Author

#take

@wayner0628 wayner0628 changed the title [copilot] rename sidecar to upload [copilot] rename sidecar to uploader Nov 12, 2024
@Future-Outlier
Copy link
Member

thank you, this is AMAZING

@Future-Outlier Future-Outlier added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Nov 12, 2024
@eapolinario eapolinario removed the untriaged This issues has not yet been looked at by the Maintainers label Nov 14, 2024
@eapolinario
Copy link
Contributor

Thank you. This should be as simple as changing the string value here, right? Please, make sure that it works end-to-end.

@wayner0628
Copy link
Contributor Author

wayner0628 commented Nov 15, 2024

I think we also need to change the file and function names? Sure, I'll make it work e2e.

@kumare3
Copy link
Contributor

kumare3 commented Dec 3, 2024

i think this has been done, can we close this?

@wayner0628
Copy link
Contributor Author

Yes!

@github-project-automation github-project-automation bot moved this from Assigned to Done in Flyte Issues/PRs maintenance Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
Status: Done
Development

No branches or pull requests

4 participants