-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[copilot] rename sidecar to uploader #5995
Labels
enhancement
New feature or request
housekeeping
Issues that help maintain flyte and keep it tech-debt free
Comments
wayner0628
added
enhancement
New feature or request
untriaged
This issues has not yet been looked at by the Maintainers
labels
Nov 12, 2024
#take |
wayner0628
changed the title
[copilot] rename sidecar to upload
[copilot] rename sidecar to uploader
Nov 12, 2024
thank you, this is AMAZING |
Future-Outlier
added
the
housekeeping
Issues that help maintain flyte and keep it tech-debt free
label
Nov 12, 2024
eapolinario
removed
the
untriaged
This issues has not yet been looked at by the Maintainers
label
Nov 14, 2024
Thank you. This should be as simple as changing the string value here, right? Please, make sure that it works end-to-end. |
|
3 tasks
i think this has been done, can we close this? |
Yes! |
github-project-automation
bot
moved this from Assigned
to Done
in Flyte Issues/PRs maintenance
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
housekeeping
Issues that help maintain flyte and keep it tech-debt free
Motivation: Why do you think this is important?
The current naming of the upload container in Copilot as
sidecar
can be confusing, especially since we also have a dedicateddownloader
container. Given that this container primarily handles upload tasks, renaming it to something more descriptive would improve readability and understanding of its role.Goal: What should the final outcome look like, ideally?
The final outcome should involve renaming all instances of
sidecar
related to the upload container—both in the UI and codebase—touploader
.Describe alternatives you've considered
NA
Propose: Link/Inline OR Additional context
No response
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: