Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Add support for protobuf version 5 in flytekit #5448

Open
2 tasks done
eapolinario opened this issue Jun 4, 2024 · 2 comments · May be fixed by flyteorg/flytekit#2946
Open
2 tasks done

[Housekeeping] Add support for protobuf version 5 in flytekit #5448

eapolinario opened this issue Jun 4, 2024 · 2 comments · May be fixed by flyteorg/flytekit#2946
Assignees
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free

Comments

@eapolinario
Copy link
Contributor

Describe the issue

Google released a new major version of the protobuf library in March/2024: https://pypi.org/project/protobuf/#history, but that version started to affect the flytekit ecosystem only after googleapis-common-protos released version 1.36.1, which dropped the constraint on the 5.X version of protobuf.

Using the new major version of protobuf broke the suggested way of using python backend described in https://github.com/protocolbuffers/protobuf/blob/main/python/README.md#implementation-backends, which involved setting an environment variable to instruct the protobuf runtime to use the python implementation. I opened googleapis/python-api-common-protos#232 to track on their side.

What if we do not do this?

We use some plugins in our CI checks that rely on the python implementation to run, since those haven't updated to the version 4 of the protobuf library.

Related component(s)

flytekit

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@eapolinario eapolinario added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Jun 4, 2024
@eapolinario eapolinario self-assigned this Jun 4, 2024
Copy link

runllm bot commented Jun 4, 2024

The issue you described involves adding support for protobuf version 5 in Flytekit. This is necessary due to the recent release of protobuf 5.0.0 and its impact on the Flytekit ecosystem, particularly when using the Python backend. The problem is exacerbated by the googleapis-common-protos library dropping constraints on protobuf versions, leading to compatibility issues.

To address this, Flytekit needs to update its dependencies and ensure compatibility with protobuf 5.0.0. This involves modifying the environment variable settings and potentially updating CI plugins that rely on the older protobuf versions.

Would you like more detail on how to proceed with these updates?

Sources:


This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not.

Mention @RunLLM to ask follow-up questions. See runllm.com for more!

@eapolinario
Copy link
Contributor Author

The original issue was fixed in https://pypi.org/project/googleapis-common-protos/1.63.2/. We should give this another try.

@eapolinario eapolinario linked a pull request Nov 22, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant