From 0a441a97c990024c0f6e07a39939fb3aa1f4b7f0 Mon Sep 17 00:00:00 2001 From: Yee Hing Tong Date: Fri, 2 Aug 2024 12:53:33 -0700 Subject: [PATCH] Amend Admin to use grpc message size (#5628) * add send arg Signed-off-by: Yee Hing Tong * Add acction to remove cache in gh runner Signed-off-by: Eduardo Apolinario * Use correct checked out path Signed-off-by: Eduardo Apolinario * Path in strings Signed-off-by: Eduardo Apolinario * Checkout repo in root Signed-off-by: Eduardo Apolinario * Use the correct path to new action Signed-off-by: Eduardo Apolinario * Do not use gh var in path to clear-action-cache Signed-off-by: Eduardo Apolinario * Remove wrong invocation of clear-action-cache Signed-off-by: Eduardo Apolinario * GITHUB_WORKSPACE is implicit in the checkout action Signed-off-by: Eduardo Apolinario * Refer to local `flyte` directory Signed-off-by: Eduardo Apolinario --------- Signed-off-by: Yee Hing Tong Signed-off-by: Eduardo Apolinario Co-authored-by: Eduardo Apolinario --- .github/actions/clear-action-cache/action.yml | 11 +++++++++++ .github/workflows/tests.yml | 6 ++++-- flyteadmin/pkg/server/service.go | 2 +- 3 files changed, 16 insertions(+), 3 deletions(-) create mode 100644 .github/actions/clear-action-cache/action.yml diff --git a/.github/actions/clear-action-cache/action.yml b/.github/actions/clear-action-cache/action.yml new file mode 100644 index 0000000000..a29347b61c --- /dev/null +++ b/.github/actions/clear-action-cache/action.yml @@ -0,0 +1,11 @@ +name: 'Clear action cache' +description: 'As suggested by GitHub to prevent low disk space: https://github.com/actions/runner-images/issues/2840#issuecomment-790492173' +runs: + using: 'composite' + steps: + - shell: bash + run: | + rm -rf /usr/share/dotnet + rm -rf /opt/ghc + rm -rf "/usr/local/share/boost" + rm -rf "$AGENT_TOOLSDIRECTORY" diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index cbce9cd054..1d69466464 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -30,12 +30,14 @@ jobs: - name: Fetch flyte code uses: actions/checkout@v4 with: - path: "${{ github.workspace }}/flyte" + path: flyte + - name: 'Clear action cache' + uses: ./flyte/.github/actions/clear-action-cache - name: Fetch flytekit code uses: actions/checkout@v4 with: repository: flyteorg/flytekit - path: "${{ github.workspace }}/flytekit" + path: flytekit - uses: conda-incubator/setup-miniconda@v3 with: auto-update-conda: true diff --git a/flyteadmin/pkg/server/service.go b/flyteadmin/pkg/server/service.go index bb09f9f615..0a7371ef68 100644 --- a/flyteadmin/pkg/server/service.go +++ b/flyteadmin/pkg/server/service.go @@ -140,7 +140,7 @@ func newGRPCServer(ctx context.Context, pluginRegistry *plugins.Registry, cfg *c grpc.UnaryInterceptor(chainedUnaryInterceptors), } if cfg.GrpcConfig.MaxMessageSizeBytes > 0 { - serverOpts = append(serverOpts, grpc.MaxRecvMsgSize(cfg.GrpcConfig.MaxMessageSizeBytes)) + serverOpts = append(serverOpts, grpc.MaxRecvMsgSize(cfg.GrpcConfig.MaxMessageSizeBytes), grpc.MaxSendMsgSize(cfg.GrpcConfig.MaxMessageSizeBytes)) } serverOpts = append(serverOpts, opts...) grpcServer := grpc.NewServer(serverOpts...)