Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow New input, output #52

Open
sychris opened this issue Sep 6, 2023 · 1 comment
Open

flow New input, output #52

sychris opened this issue Sep 6, 2023 · 1 comment
Labels
bug Something isn't working discussion

Comments

@sychris
Copy link
Contributor

sychris commented Sep 6, 2023

flow New input does not eject a value box meaning you cant pull a connection off of them. and must use the input or output of another node. this also has a side effect of not being able to make a "passthrough" flow there implementation details get filled out later.
Untitled

@GabiGrin
Copy link
Contributor

What you refer to as the "value box" is what I call a "pin" (or inport/outport in FBP lingo
Main inputs/outputs can be thought of floating inport/outports.

I'll start with the second issue - a valid (and relatively easy) bug. Creating passthrough nodes is a very interesting motivator for fixing that.

The first issue is more thought-provoking as it raises questions regarding the whole implementation of main inport/outports, which TBH I am not 100% happy with:

  1. it's hard to understand
  2. it creates issues like a conflict between the drag behavior and drag-to-connect behavior

The only alternative I can think of is a built-in node that exposes main inputs or main outputs, which I am not happy with either

@GabiGrin GabiGrin added bug Something isn't working discussion labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discussion
Projects
None yet
Development

No branches or pull requests

2 participants