Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aliasfy Packages are ignored in the Pool Preperation #44

Open
Schuchie opened this issue Apr 2, 2024 · 2 comments
Open

Aliasfy Packages are ignored in the Pool Preperation #44

Schuchie opened this issue Apr 2, 2024 · 2 comments
Assignees
Labels
analysis enhancement New feature or request

Comments

@Schuchie
Copy link

Schuchie commented Apr 2, 2024

Describe the bug
Aliasfy packages are filtered from the pool preparation command through the following change:

To Reproduce
Steps to reproduce the behavior:

  1. Have a aliasfy package in the sfdx-project.hson and executed the pool preparation command without an release-config:
  2. sfp orchestrator:prepare -f config/project-ci-stage-pool-def.json -v devhub --loglevel trace
  3. The builded packages does not contain any aliasfy package

Expected behavior
Aliasfy packages are included in the pool creation. It should take the "default"-Package if exists.

Screenshots
If applicable, add screenshots to help explain your problem.

Platform Details (please complete the following information):

  • OS: MacOs/Ubuntu
  • Version [e.g. CLI Version eg: 1.6.6]: @flxbl-io/sfp/38.3.0 darwin-arm64 node-v20.6.1
  • Salesforce CLI(sfdx cli) Version: @salesforce/cli/2.30.8 darwin-arm64 node-v20.6.1
  • CI Platform: GitHub

Additional context
The following line of code is filtering aliasfy packages in the pool creation:

@dieffrei dieffrei self-assigned this May 17, 2024
@dieffrei
Copy link
Collaborator

@azlam-abdulsalam any thoughts, on this one?
I think it makes sense, usually, you could have a default configuration you want to deploy to scratch orgs

@dieffrei dieffrei added the enhancement New feature or request label Jul 16, 2024
@dieffrei
Copy link
Collaborator

dieffrei commented Aug 7, 2024

@Schuchie fyi this feature will be available on aliasifyv2, however, there is no ETA yet, as it is under development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants