Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: exec: restrict options passed to job shell #130

Open
grondo opened this issue Jan 28, 2022 · 0 comments
Open

imp: exec: restrict options passed to job shell #130

grondo opened this issue Jan 28, 2022 · 0 comments

Comments

@grondo
Copy link
Contributor

grondo commented Jan 28, 2022

After #128 is merged, flux-imp exec will have the ability to pass arbitrary options to the job shell. Since the job shell will be running as the guest user, this opens the ability for the instance owner to modify shell behavior without explicit permission from the submitting user. This could, for example, allow the instance owner to add an --initrc= option to the shell and execute arbitrary code as guest user.

This functionality is necessary for the system instance, in order to at least supply a --reconnect option to allow for recoverable jobs after a broker restart. However, before non-system multi-user instances are supported, we should add some way to restrict the options passed down to the job shell, so that arbitrary, non-system users are limited in what options they can pass to a job shell.

For now, however, this issue would only be a problem if a non-system user was listed in allowed-users and they were able to execute the IMP. We suggest only the system instance owner, e.g. user flux be listed in allowed-users and that user be the only one allowed to execute flux-imp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant