Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devtools_extensions] build_and_copy failing in newer flutter versions #8639

Closed
adsonpleal opened this issue Dec 17, 2024 · 6 comments
Closed

Comments

@adsonpleal
Copy link

The web renderer flag (--web-renderer) was removed in recent flutter versions on the dev channel. So running dart run devtools_extensions build_and_copy is causing this error:

Building package executable...
Built devtools_extensions:devtools_extensions.
[build_and_copy] Building the extension Flutter web app...
Could not find an option named "--web-renderer".

Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options.
Unhandled exception:
ProcessException: Failed with exit code: 64
  Command: flutter build web --web-renderer canvaskit --pwa-strategy=offline-first --release --no-tree-shake-icons
#0      BuildExtensionCommand._runProcess (file:///Users/adson.leal/.pub-cache/hosted/pub.dev/devtools_extensions-0.2.2/bin/_build_and_copy.dart:134:7)
<asynchronous suspension>
#1      BuildExtensionCommand.run (file:///Users/adson.leal/.pub-cache/hosted/pub.dev/devtools_extensions-0.2.2/bin/_build_and_copy.dart:57:5)
<asynchronous suspension>
#2      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#3      SharedStdIn.terminate (package:io/src/shared_stdin.dart:91:3)
<asynchronous suspension>
#4      main (file:///Users/adson.leal/.pub-cache/hosted/pub.dev/devtools_extensions-0.2.2/bin/devtools_extensions.dart:16:3)
<asynchronous suspension>

Since now the default web renderer is canvaskit I think we should just remove the flag from here.

This problem made us revert the this PR on flutter/packages.

@adsonpleal
Copy link
Author

@kenzieschmoll I can also make this change if you don't mind.

@stuartmorgan Just tagging you so you're aware of this discussion.

@kenzieschmoll
Copy link
Member

Hi @adsonpleal just seeing this issue. I prepared a fix here: #8640

@adsonpleal
Copy link
Author

Hey @kenzieschmoll! Perfect!

@adsonpleal
Copy link
Author

@kenzieschmoll should I close this one since #8640 got merged?

@adsonpleal
Copy link
Author

Or do we wait for the pub release?

@kenzieschmoll
Copy link
Member

kenzieschmoll commented Dec 17, 2024

I just published devtools_extensions. So we can close this now. Thank you for flagging, you should be unblocked for your shared_preferences PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants