Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove permission_handler #44

Open
ccadieux opened this issue May 5, 2021 · 0 comments
Open

Remove permission_handler #44

ccadieux opened this issue May 5, 2021 · 0 comments
Labels

Comments

@ccadieux
Copy link

ccadieux commented May 5, 2021

Having permission_handler as part of this library makes it hard to use. We use permission_handler in our app so now if we want to update permission_handler we need to use dependency_overrides to work with this package.

Most libraries just tell you what permissions are required in the Readme and it's the responsibility of the developers to handle that. Using the example app to show that would be better than having this dependency as part of the package.

Looking at closed PRs there are 4 that reference permission_handler issues. Seems like this will continue until you remove the dependency.

@beygee beygee added the feature label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants