Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design: make codes related to Fluidex and codes not decouple better #204

Open
lispc opened this issue Jun 27, 2021 · 6 comments
Open

design: make codes related to Fluidex and codes not decouple better #204

lispc opened this issue Jun 27, 2021 · 6 comments
Labels

Comments

@lispc
Copy link
Member

lispc commented Jun 27, 2021

so dingir-exchange can be used by others more easily

@lispc lispc added the longterm label Jun 27, 2021
@lispc lispc changed the title design: make codes related to fludiex and codes not decouple better design: make codes related to Fluidex and codes not decouple better Jun 27, 2021
@lispc lispc pinned this issue Jun 27, 2021
@gcomte
Copy link
Contributor

gcomte commented Aug 13, 2021

FYI: I've created an Etherum-less version of dingir exchange --> https://github.com/gcomte/dingir-exchange

@0xmountaintop
Copy link
Member

FYI: I've created an Etherum-less version of dingir exchange --> https://github.com/gcomte/dingir-exchange

Looks nice :D

@0xmountaintop
Copy link
Member

0xmountaintop commented Aug 16, 2021

@gcomte you might also want to remove account table's l2_pubkey
combine it as

[derive(sqlx::FromRow, Debug, Clone, Serialize)]
pub struct AccountDesc {
    pub id: i32, // TODO: i32 or i64?
    pub pubkey: String,
}

pubkey can be used to check singnature. you might wanna remove OrderCommitment and implement your own signature verification logic, for example: #59 (comment)

@lispc
Copy link
Member Author

lispc commented Aug 17, 2021

// TODO(not urgent): we should move nonce/sig_verify to the rollup_state_manager process later?

@lispc
Copy link
Member Author

lispc commented Aug 17, 2021

and make dingir-exchange more 'internal service'

@gcomte
Copy link
Contributor

gcomte commented Aug 23, 2021

pubkey can be used to check singnature. you might wanna remove OrderCommitment and implement your own signature verification logic, for example: #59 (comment)

I just removed the user management altogether. We will take care of it with an external service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants