Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedot implicitly removed from v1.16/debian-logzio #1442

Open
b-hub opened this issue Jun 15, 2023 · 3 comments
Open

Dedot implicitly removed from v1.16/debian-logzio #1442

b-hub opened this issue Jun 15, 2023 · 3 comments

Comments

@b-hub
Copy link

b-hub commented Jun 15, 2023

As of v1.16/debian-logzio, the default dedot filtering is no longer applied, so labels and annotations are now sent to logzio without their dots being replaced by underscores.

This looks to have been introduced between v1.15 and v1.16, where there was an upgrade for fluent-plugin-kubernetes_metadata_filter 2.13.0 to 3.2.0 (see the diff here) - was this known / intended?

fluent-plugin-dedot_filter now appears to be an explicit dependency for some of the other images (e.g. elasticsearch8) - https://github.com/fluent/fluentd-kubernetes-daemonset/blob/master/templates/Gemfile.erb#L32.

Could fluent-plugin-dedot_filter be added to Gemfile for logzio as well?

The logzio-k8s image has also added this in as a Gem, however it is on an older version of the fluentd-kubernetes-daemonset.

Thanks

@daipom
Copy link
Contributor

daipom commented Oct 7, 2024

Elasticsearch fails to accept these values because of this conflict.

@daipom
Copy link
Contributor

daipom commented Oct 7, 2024

We should add fluent-plugin-dedot_filter to each daemonset.

@daipom
Copy link
Contributor

daipom commented Oct 7, 2024

Maybe we should fix the default config for elasticsearch daemonset.

@daipom daipom moved this to To-Do in Fluentd Kanban Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To-Do
Development

No branches or pull requests

3 participants