Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subsetting of observations and om for oem() to be done in mp() #22

Open
iagomosqueira opened this issue Jul 2, 2020 · 0 comments
Open

Subsetting of observations and om for oem() to be done in mp() #22

iagomosqueira opened this issue Jul 2, 2020 · 0 comments

Comments

@iagomosqueira
Copy link
Member

The whole of observations and deviances get passed to oem inside goFish, at mp.R:220-221

ctrl.oem$observations <- observations(oem)
ctrl.oem$stk <- stk.om

It would make writing oem functions simpler if those two where subset before calling oem@method, so no datayears subsetting inside the oem function: stk, observations and deviances will finish in the last data year, as determined by args.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iagomosqueira