Skip to content
This repository has been archived by the owner on Jan 27, 2024. It is now read-only.

Consider a bower package? #9

Open
fraserxu opened this issue Dec 6, 2013 · 10 comments
Open

Consider a bower package? #9

fraserxu opened this issue Dec 6, 2013 · 10 comments

Comments

@fraserxu
Copy link
Contributor

fraserxu commented Dec 6, 2013

I've been using this in my project, but we are using bower as the package manager. Have you consider to make it installable through bower?

BTW, in order to use this, I also have to include underscore in my bower.json file, I want something like angular-underscore in my json file, thanks!

@floydwch
Copy link
Owner

floydwch commented Dec 6, 2013

I've added bower.json without testing, would you mind to test it?

And since considering Lo-Dash, the decision of underscore or Lo-Dash as the infrastructure is remained with users, i.e., you can include 'underscore' or 'lodash', depends on you .

@fraserxu
Copy link
Contributor Author

fraserxu commented Dec 6, 2013

If you say so, why not have another one named angular-lodash. The name would be confusing if you let people choose which library to use, no?

@floydwch
Copy link
Owner

floydwch commented Dec 6, 2013

@fraserxu Because Lo-Dash is as a drop-in replacement for underscore, if include underscore directly in this package, one can't have other choice for consideration, so leave it for users might be better.

Also, this package's description is "Underscore adapter for AngularJS", i.e., it's just an adapter, not an implementation of underscore.

@sentenza
Copy link

@floydsoft I've tested installing ver. 0.4.0 but I have this error in return:

bower angular-underscore#~0.4.0     ENORESTARGET No tag found that was able to satisfy ~0.4.0

@Zmetser
Copy link

Zmetser commented Dec 21, 2013

Indeed. Tagging the releases would be nice. But in the meantime just do bower angular-underscore it'll check out the master.

bower info angular-underscore

@sentenza
Copy link

Yes, I already did that to fix the dependency.

@fraserxu
Copy link
Contributor Author

@sentenza You can only try install it directly without adding the version.

@tomaszkrym
Copy link

+1 for tagging the version - my webapp stopped working because of the fact, that angular-underscore was updated to latest version, while I had older version of underscore in bower.

@floydwch
Copy link
Owner

@tomaszkrym I added the tag v0.5.0, could you mind to test for it?

@tomaszkrym
Copy link

@floydsoft it works fine, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants