Skip to content
This repository has been archived by the owner on Feb 8, 2022. It is now read-only.

Multiple issues fixed and new features implemented #308

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Akhunzaada
Copy link
Contributor

@Akhunzaada Akhunzaada commented Nov 6, 2020

Akhunzaada and others added 6 commits July 11, 2018 16:02
The crash was caused because of the options secondDateAfterFirst which was added in the commit db112c9
The issue was only reproduced when the flag secondDateAfterFirst was set to true and the WheelDayOfMonthPicker view was visible.
The listener addOnDateChangedListener was updating the second picker with the minimum date whereas when the WheelDayOfMonthPicker's visibility was gone, the picker had no items resulting in a crash in getItem() method of the WheelPicker adapter.
The crash was caused when today's label was set using todayText() method or from xml. The WheelDayPicker was considering the label from resources for today position instead of the custom set label.
# Conflicts:
#	singledateandtimepicker/src/main/java/com/github/florent37/singledateandtimepicker/widget/WheelDayPicker.java
#	singledateandtimepicker/src/main/java/com/github/florent37/singledateandtimepicker/widget/WheelPicker.java
Other florent37#306, florent37#303, florent37#269, florent37#290
The issues were mainly caused because of incorrect retrieving of today item index.
Optimized today item index search on scroll.
targetSdkVersion set to API 30
Dependency versions updated
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant