Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check and fix indirect lighting power #38

Open
AlexandreLamure opened this issue Feb 8, 2022 · 5 comments
Open

Check and fix indirect lighting power #38

AlexandreLamure opened this issue Feb 8, 2022 · 5 comments
Assignees
@flomonster @AlexandreLamure
Labels
bug Something isn't working Priority High The next feature to implement

Comments

@AlexandreLamure
Copy link
Collaborator

AlexandreLamure commented Feb 8, 2022 •
edited
Loading

Indirect lighting seems too weak
Blender:
With "bright sky" (using background color as light)
blender1

Our results :
sponza (1)
@AlexandreLamure AlexandreLamure added the bug Something isn't working label Feb 8, 2022
@AlexandreLamure
Copy link
Collaborator Author

AlexandreLamure commented Feb 9, 2022 •
edited
Loading

It seems to come from the BRDF.
More specifically, the indirect version of the BRDF (eval_indirect()).

@AlexandreLamure
Copy link
Collaborator Author

AlexandreLamure commented Mar 3, 2022 •
edited
Loading

There are also some weird artifacts in our version
image
The normals seem to flipped sometimes (maybe the NDF ?). Or it could be a bug in the metalness values

@AlexandreLamure
Copy link
Collaborator Author

Better examples (indirect light only, using background color as the light)

Blender:
image

Ours:
image

@AlexandreLamure AlexandreLamure added the Priority High The next feature to implement label Mar 25, 2022
@AlexandreLamure
Copy link
Collaborator Author

Other tests:
1 - With point light
Blender:
ref1
Our version :
result1
Our version with eval_direct only:
result1_2

2 - With bright sky
Blender:
ref2
Our version :
result2
Our version with eval_direct only:
result2_2

@AlexandreLamure
Copy link
Collaborator Author

AlexandreLamure commented Jan 18, 2023 •
edited
Loading

We think there is a problem in metalness

Blender:
image

Ours:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flomonster flomonster

@AlexandreLamure AlexandreLamure

Labels
bug Something isn't working Priority High The next feature to implement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flomonster @AlexandreLamure