Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can't actually use the Routing or the Exception providers standalone #2

Open
mTorres opened this issue Jan 17, 2015 · 1 comment

Comments

@mTorres
Copy link

mTorres commented Jan 17, 2015

I was looking up a way to use the powerful Symfony router (specially yaml defined routes with catching for PROD) with Silex and I've found your repository. I very much like your ChainedRouter which adds, on top of the Silex router the Symfony one.
As I understand it, this repository is here in order to use the providers outside the Brick project. But unfortunatelly the Rotuing provider is tightly coupled with the Brick repository where the Brick\Routing namespace lives.
Is there any chance to move the Brick\Routing namespace from flint\Brick to this repository? I am willing to create a PR but I won't start if you won't go this path (and I would understand completely, is your project after all).
Of course I can pull in the flint/Brick package, but as for the existence of this one, I though it is possible to extract more in order to truly reuse your fantastic providers.
PS: The same issue happens with the Exception Provider which is coupled with the Controller\ ExceptionController class

@praswicaksono
Copy link

👍 and it would be better separate from another service provider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants