Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It accepts anything as username/password request #9

Open
robinvdvleuten opened this issue Sep 23, 2015 · 0 comments
Open

It accepts anything as username/password request #9

robinvdvleuten opened this issue Sep 23, 2015 · 0 comments

Comments

@robinvdvleuten
Copy link

I found an issue in the UsernamePasswordAuthenticator. When I send a request with the following body;

{
    "test": "[email protected]",
    "fault": "johndoe"
}

It returns a valid token because of this line;

list($username, $password) = array_values($body + ['username' => null, 'password' => null]);

Is it possible to add some (configurable) validation on the JSON request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant