stapi::refresh_ctable does not handle SQL generation errors

[mutability]

If gen_refresh_ctable_sql returns 0 to indicate an error, refresh_ctable does not handle this and tries to execute it as SQL, which fails:

03/17/2016 12:05:15 speedtable refresh of airline_fleets failed: ERROR:  syntax error at or near "0"
LINE 1: 0
        ^

[resuna]

I've got a fix for this in the stapi-fixes branch.

What was the root cause of gen_refresh_ctable_sql returning zero? I'm not seeing how that could happen without a problem elsewhere.

[mutability]

The cause was #53

[resuna]

Ah, OK. This should make that kind of failure easier to debug anyway.

I'll get started on #53 - that's not a use case I had ever considered.

[resuna]

I have rebased the stapi-fixes branch up to master. Can you please verify that it fixes this problems so I can merge it back?

[resuna]

Fixed in stapi-fixes.