stapi-based speedtables definitions aren't regenerated if speedtables is updated

[lehenbauer]

"Normal" speedtables are automatically regenerated if their definition changes or if speedtables itself is updated. Speedtables generated by stapi based on DDL read from PostgreSQL are not automatically regenerated.

This can result in strange errors if, for instance, a new version of Pgtcl is put in place. Stapi-based speedtables will reference the old while classic ctables-based speedtables will reference the new, and strange behaviors result.

Please make stapi C extensions be regenerated if speedtables are updated with a new version.

[resuna]

That's a good point. Let me dig into the code... I can see a couple of
approaches. The code in STAPI to decide whether to rebuild the speedtable
may simply be redundant now, and if so I can punt that decision up one
level to the Speedtables code.

On Mon, Jun 4, 2012 at 3:29 PM, Karl Lehenbauer <
[email protected]

wrote:

"Normal" speedtables are automatically regenerated if their definition
changes or if speedtables itself is updated. Speedtables generated by
stapi based on DDL read from PostgreSQL are not automatically regenerated.

This can result in strange errors if, for instance, a new version of Pgtcl
is put in place. Stapi-based speedtables will reference the old while
classic ctables-based speedtables will reference the new, and strange
behaviors result.

Please make stapi C extensions be regenerated if speedtables are updated
with a new version.

---

Reply to this email directly or view it on GitHub:
#26

[lehenbauer]

There is a check in stapi, actually. init_ctable uses an entire file to track the version number of speedtables and the version number (0.1) of stapi, so the candidate places to make the changes are clear and the main choices are to always increment the speetables package version for every change or to add some additional thing to generated/saved/compared version info, like perhaps the last git commit id.

[resuna]

I was going to say it could use the same list as ctables but the
pgtcl-based stapi doesn't necessarily even have that loaded.

I won't have time to work on this until after the 15th and possibly the
weekend following. Is that ok?
On Jun 10, 2012 11:21 AM, "Karl Lehenbauer" <
[email protected]>
wrote:

There is a check in stapi, actually. init_ctable uses an entire file to
track the version number of speedtables and the version number (0.1) of
stapi, so the candidate places to make the changes are clear and the main
choices are to always increment the speetables package version for every
change or to add some additional thing to generated/saved/compared version
info, like perhaps the last git commit id.

---

Reply to this email directly or view it on GitHub:
#26 (comment)

[lehenbauer]

Sure, no worries.