New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo, and lack of VPC support for RDS/Restore from snapshot #173

Open

cbake6807 opened this issue Sep 4, 2013 · 0 comments

cbake6807 commented Sep 4, 2013

There seems to be a typo in the param['engine'] at the very end of this line
https://github.com/rightscale/right_aws/blob/master/lib/rds/right_rds_interface.rb#L799

unless params[:enginel].right_blank?

should be

unless params[:engine].right_blank?

Also, the request_hash doesn't include an overridable PubliclyAccessible key, for setting the value to FALSE and creating the RDS instance in a VPC

http://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_RestoreDBInstanceFromDBSnapshot.html

Thanks,
Chris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment