Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only top 1000 items returned #848

Open
ianket opened this issue Dec 19, 2024 · 1 comment
Open

Only top 1000 items returned #848

ianket opened this issue Dec 19, 2024 · 1 comment

Comments

@ianket
Copy link

ianket commented Dec 19, 2024

When fetching more than 1000 entries of an eloquent object, I only receive the top 1000 entries. This seems to be caused by
src/Drivers/EloquentEntitySet.php , because it checks less and equal which causes it to break the loop if it is exactly the chunk size length (which would be the exact size because of the chunksize). If i locally change it form <= to < it works correctly.

I'm only not entirely sure why this issue only occurred now and not a year ago when this was added, might be a me-issue if i forgot to update my packages regularly ;)

@27pchrisl
Copy link
Contributor

Hi @ianket, I can't immediately see a reason for this, do you have config items lodata.pagination.max or lodata.pagination.default set ? If you recently upgraded these might be new...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants