Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: timeout txs that take more than 1ms to execute #26

Open
bertmiller opened this issue Jul 3, 2024 · 1 comment
Open

feat: timeout txs that take more than 1ms to execute #26

bertmiller opened this issue Jul 3, 2024 · 1 comment
Labels
A-builder Issues related to the core block building protocol

Comments

@bertmiller
Copy link
Member

Occasionally, because some precompiles are slow, there are transactions that take disproportionately long to execute (eg over 1ms). We should have a feature that allows us to time out these and drop them.

@ryanschneider
Copy link
Contributor

We might want to consider using something other than wall time, I could see a pathological case where we discard all txs because of some noisy neighbor. Not sure if revm has some other metrics (besides gas) that we could consider instead.

Also, I had a related idea: instead of outright discarding the transaction, we could select! on the EVM async future and a timer, and if the timer is hit send the EVM future to a "low priority" channel that we continue to try to execute the transaction on until the next block.

Not sure if doing all that is worth the work though, but could be if these slow txs sometimes still yield value.

@ferranbt ferranbt added the A-builder Issues related to the core block building protocol label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-builder Issues related to the core block building protocol
Projects
None yet
Development

No branches or pull requests

3 participants