Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support num_epochs in config #83

Open
zqhuang211 opened this issue Aug 15, 2024 · 2 comments
Open

Support num_epochs in config #83

zqhuang211 opened this issue Aug 15, 2024 · 2 comments
Assignees
@liPatrick

Comments

@zqhuang211
Copy link
Contributor

The num_epochs configuration parameter, intended to activate when max_steps=0, is currently causing model training to break.

Need to investigate the underlying cause and implement a fix.
@liPatrick liPatrick mentioned this issue Aug 20, 2024
Merged
@juberti
Copy link
Contributor

juberti commented Aug 21, 2024

I think this is due an incompatibility with streaming=True, where the length of the epoch is not known in advance.

@liPatrick
Copy link
Contributor

Fix: #90

You need to have an estimate of the dataset size ahead of time for this to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liPatrick liPatrick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@juberti @liPatrick @zqhuang211