diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index 6d1cf8c6331..d7e8ccf0d2a 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -1417,13 +1417,13 @@ parameters: path: app/GedcomRecord.php - - message: '#^Strict comparison using \!\=\= between non\-empty\-string and '''' will always evaluate to true\.$#' + message: '#^Strict comparison using \!\=\= between lowercase\-string&non\-falsy\-string and '''' will always evaluate to true\.$#' identifier: notIdentical.alwaysTrue count: 1 path: app/GedcomRecord.php - - message: '#^Strict comparison using \!\=\= between non\-falsy\-string and '''' will always evaluate to true\.$#' + message: '#^Strict comparison using \!\=\= between non\-empty\-string and '''' will always evaluate to true\.$#' identifier: notIdentical.alwaysTrue count: 1 path: app/GedcomRecord.php @@ -11532,78 +11532,12 @@ parameters: count: 1 path: resources/views/modules/recent_changes/changes-list.phtml - - - message: '#^Access to an undefined property object\:\:\$record\.$#' - identifier: property.notFound - count: 12 - path: resources/views/modules/recent_changes/changes-table.phtml - - - - message: '#^Access to an undefined property object\:\:\$time\.$#' - identifier: property.notFound - count: 2 - path: resources/views/modules/recent_changes/changes-table.phtml - - - - message: '#^Access to an undefined property object\:\:\$user\.$#' - identifier: property.notFound - count: 1 - path: resources/views/modules/recent_changes/changes-table.phtml - - - - message: '#^Cannot call method fullName\(\) on mixed\.$#' - identifier: method.nonObject - count: 1 - path: resources/views/modules/recent_changes/changes-table.phtml - - - - message: '#^Cannot call method sortName\(\) on mixed\.$#' - identifier: method.nonObject - count: 1 - path: resources/views/modules/recent_changes/changes-table.phtml - - - - message: '#^Cannot call method tag\(\) on mixed\.$#' - identifier: method.nonObject - count: 9 - path: resources/views/modules/recent_changes/changes-table.phtml - - - - message: '#^Cannot call method timestamp\(\) on mixed\.$#' - identifier: method.nonObject - count: 1 - path: resources/views/modules/recent_changes/changes-table.phtml - - - - message: '#^Cannot call method url\(\) on mixed\.$#' - identifier: method.nonObject - count: 1 - path: resources/views/modules/recent_changes/changes-table.phtml - - - - message: '#^Cannot call method userName\(\) on mixed\.$#' - identifier: method.nonObject - count: 1 - path: resources/views/modules/recent_changes/changes-table.phtml - - message: '#^Parameter \#1 \$value of function e expects Illuminate\\Contracts\\Support\\DeferringDisplayableValue\|Illuminate\\Contracts\\Support\\Htmlable\|string\|null, int given\.$#' identifier: argument.type count: 1 path: resources/views/modules/recent_changes/changes-table.phtml - - - message: '#^Parameter \#1 \$value of function e expects Illuminate\\Contracts\\Support\\DeferringDisplayableValue\|Illuminate\\Contracts\\Support\\Htmlable\|string\|null, mixed given\.$#' - identifier: argument.type - count: 3 - path: resources/views/modules/recent_changes/changes-table.phtml - - - - message: '#^Parameter \#1 \(mixed\) of echo cannot be converted to string\.$#' - identifier: echo.nonString - count: 3 - path: resources/views/modules/recent_changes/changes-table.phtml - - message: '#^Parameter \#1 \$value of function e expects Illuminate\\Contracts\\Support\\DeferringDisplayableValue\|Illuminate\\Contracts\\Support\\Htmlable\|string\|null, int given\.$#' identifier: argument.type @@ -12084,102 +12018,12 @@ parameters: count: 1 path: resources/views/modules/yahrzeit/list.phtml - - - message: '#^Access to an undefined property object\:\:\$fact\.$#' - identifier: property.notFound - count: 2 - path: resources/views/modules/yahrzeit/table.phtml - - - - message: '#^Access to an undefined property object\:\:\$fact_date\.$#' - identifier: property.notFound - count: 1 - path: resources/views/modules/yahrzeit/table.phtml - - - - message: '#^Access to an undefined property object\:\:\$individual\.$#' - identifier: property.notFound - count: 7 - path: resources/views/modules/yahrzeit/table.phtml - - - - message: '#^Access to an undefined property object\:\:\$yahrzeit_date\.$#' - identifier: property.notFound - count: 3 - path: resources/views/modules/yahrzeit/table.phtml - - - - message: '#^Cannot access property \$anniv on mixed\.$#' - identifier: property.nonObject - count: 2 - path: resources/views/modules/yahrzeit/table.phtml - - - - message: '#^Cannot call method alternateName\(\) on mixed\.$#' - identifier: method.nonObject - count: 2 - path: resources/views/modules/yahrzeit/table.phtml - - - - message: '#^Cannot call method display\(\) on mixed\.$#' - identifier: method.nonObject - count: 2 - path: resources/views/modules/yahrzeit/table.phtml - - - - message: '#^Cannot call method fullName\(\) on mixed\.$#' - identifier: method.nonObject - count: 1 - path: resources/views/modules/yahrzeit/table.phtml - - - - message: '#^Cannot call method julianDay\(\) on mixed\.$#' - identifier: method.nonObject - count: 2 - path: resources/views/modules/yahrzeit/table.phtml - - - - message: '#^Cannot call method sortName\(\) on mixed\.$#' - identifier: method.nonObject - count: 1 - path: resources/views/modules/yahrzeit/table.phtml - - - - message: '#^Cannot call method tree\(\) on mixed\.$#' - identifier: method.nonObject - count: 2 - path: resources/views/modules/yahrzeit/table.phtml - - - - message: '#^Cannot call method url\(\) on mixed\.$#' - identifier: method.nonObject - count: 1 - path: resources/views/modules/yahrzeit/table.phtml - - - - message: '#^Parameter \#1 \$n of static method Fisharebest\\Webtrees\\I18N\:\:number\(\) expects float, mixed given\.$#' - identifier: argument.type - count: 1 - path: resources/views/modules/yahrzeit/table.phtml - - message: '#^Parameter \#1 \$value of function e expects Illuminate\\Contracts\\Support\\DeferringDisplayableValue\|Illuminate\\Contracts\\Support\\Htmlable\|string\|null, int given\.$#' identifier: argument.type count: 1 path: resources/views/modules/yahrzeit/table.phtml - - - message: '#^Parameter \#1 \$value of function e expects Illuminate\\Contracts\\Support\\DeferringDisplayableValue\|Illuminate\\Contracts\\Support\\Htmlable\|string\|null, mixed given\.$#' - identifier: argument.type - count: 5 - path: resources/views/modules/yahrzeit/table.phtml - - - - message: '#^Parameter \#1 \(mixed\) of echo cannot be converted to string\.$#' - identifier: echo.nonString - count: 4 - path: resources/views/modules/yahrzeit/table.phtml - - message: '#^Access to an undefined property object\:\:\$change_id\.$#' identifier: property.notFound diff --git a/resources/views/lists/anniversaries-table.phtml b/resources/views/lists/anniversaries-table.phtml index e596d34a2da..9599e8f3dbf 100644 --- a/resources/views/lists/anniversaries-table.phtml +++ b/resources/views/lists/anniversaries-table.phtml @@ -57,10 +57,10 @@ use Illuminate\Support\Collection; $record->sex()]) ?> - + date()->display($record->tree(), null, true) ?> - + anniv ?> diff --git a/resources/views/lists/families-table.phtml b/resources/views/lists/families-table.phtml index 7de74045617..cb54a77dfc9 100644 --- a/resources/views/lists/families-table.phtml +++ b/resources/views/lists/families-table.phtml @@ -223,7 +223,7 @@ $("#") - + getAllMarriageDates()) : ?>
display($tree, null, true) ?>
@@ -254,7 +254,7 @@ $("#") - + $family->lastChangeTimestamp()]) ?> diff --git a/resources/views/lists/individuals-table.phtml b/resources/views/lists/individuals-table.phtml index a994e9d847b..d62ee635cda 100644 --- a/resources/views/lists/individuals-table.phtml +++ b/resources/views/lists/individuals-table.phtml @@ -224,7 +224,7 @@ $("#") getEstimatedBirthDate(); ?> - + getAllBirthDates(); ?> @@ -255,7 +255,7 @@ $("#") getAllDeathDates() ?> - +
display($tree, null, true) ?>
@@ -284,7 +284,7 @@ $("#") - + $individual->lastChangeTimestamp()]) ?> @@ -339,4 +339,3 @@ $("#") - diff --git a/resources/views/lists/locations-table.phtml b/resources/views/lists/locations-table.phtml index 1ef3976c06b..f8086a0504b 100644 --- a/resources/views/lists/locations-table.phtml +++ b/resources/views/lists/locations-table.phtml @@ -90,7 +90,7 @@ $count_families = DB::table('families') - + $location->lastChangeTimestamp()]) ?> diff --git a/resources/views/lists/media-table.phtml b/resources/views/lists/media-table.phtml index b1eebfebe67..26178420120 100644 --- a/resources/views/lists/media-table.phtml +++ b/resources/views/lists/media-table.phtml @@ -118,7 +118,7 @@ $count_sources = DB::table('sources') - + $media_object->lastChangeTimestamp()]) ?> diff --git a/resources/views/lists/notes-table.phtml b/resources/views/lists/notes-table.phtml index 8f59ae43b07..ab5fe03d857 100644 --- a/resources/views/lists/notes-table.phtml +++ b/resources/views/lists/notes-table.phtml @@ -128,7 +128,7 @@ $count_sources = DB::table('sources') - + $note->lastChangeTimestamp()]) ?> diff --git a/resources/views/lists/repositories-table.phtml b/resources/views/lists/repositories-table.phtml index 76d754238f6..6c322f61b85 100644 --- a/resources/views/lists/repositories-table.phtml +++ b/resources/views/lists/repositories-table.phtml @@ -71,7 +71,7 @@ $count_sources = DB::table('sources') - + $repository->lastChangeTimestamp()]) ?> diff --git a/resources/views/lists/sources-table.phtml b/resources/views/lists/sources-table.phtml index 41a96578887..d5d5515d08c 100644 --- a/resources/views/lists/sources-table.phtml +++ b/resources/views/lists/sources-table.phtml @@ -151,7 +151,7 @@ $count_notes = DB::table('other') - + $source->lastChangeTimestamp()]) ?> diff --git a/resources/views/lists/submitters-table.phtml b/resources/views/lists/submitters-table.phtml index 01d9d1890b2..73ab1be9ccd 100644 --- a/resources/views/lists/submitters-table.phtml +++ b/resources/views/lists/submitters-table.phtml @@ -90,7 +90,7 @@ $count_families = DB::table('families') xref()] ?? 0) ?> - + $submitter->lastChangeTimestamp()]) ?> diff --git a/resources/views/lists/surnames-table.phtml b/resources/views/lists/surnames-table.phtml index f6df1dbc4f9..7138202ec9b 100644 --- a/resources/views/lists/surnames-table.phtml +++ b/resources/views/lists/surnames-table.phtml @@ -47,7 +47,7 @@ use Fisharebest\Webtrees\Tree; $surns) : ?> - + diff --git a/resources/views/modules/recent_changes/changes-table.phtml b/resources/views/modules/recent_changes/changes-table.phtml index c6ce0e29cbc..7d144ed368b 100644 --- a/resources/views/modules/recent_changes/changes-table.phtml +++ b/resources/views/modules/recent_changes/changes-table.phtml @@ -2,7 +2,9 @@ declare(strict_types=1); +use Fisharebest\Webtrees\Contracts\UserInterface; use Fisharebest\Webtrees\Family; +use Fisharebest\Webtrees\GedcomRecord; use Fisharebest\Webtrees\I18N; use Fisharebest\Webtrees\Individual; use Fisharebest\Webtrees\Location; @@ -11,16 +13,17 @@ use Fisharebest\Webtrees\Note; use Fisharebest\Webtrees\Repository; use Fisharebest\Webtrees\Source; use Fisharebest\Webtrees\Submitter; +use Fisharebest\Webtrees\Timestamp; use Fisharebest\Webtrees\View; use Illuminate\Support\Collection; /** - * @var int $limit_high - * @var int $limit_low - * @var array> $order - * @var Collection $rows - * @var bool $show_date - * @var bool $show_user + * @var int $limit_high + * @var int $limit_low + * @var array> $order + * @var Collection $rows + * @var bool $show_date + * @var bool $show_user */ ?> @@ -88,7 +91,7 @@ use Illuminate\Support\Collection; record->fullName() ?> - + $row->time]) ?> diff --git a/resources/views/modules/todo/research-tasks.phtml b/resources/views/modules/todo/research-tasks.phtml index 88651f33bf2..edc67ce8639 100644 --- a/resources/views/modules/todo/research-tasks.phtml +++ b/resources/views/modules/todo/research-tasks.phtml @@ -44,7 +44,7 @@ use Illuminate\Support\Collection; - + date()->display() ?> diff --git a/resources/views/modules/yahrzeit/table.phtml b/resources/views/modules/yahrzeit/table.phtml index 9e94b1195c5..d79ea085183 100644 --- a/resources/views/modules/yahrzeit/table.phtml +++ b/resources/views/modules/yahrzeit/table.phtml @@ -2,13 +2,16 @@ declare(strict_types=1); +use Fisharebest\Webtrees\Date; +use Fisharebest\Webtrees\Fact; use Fisharebest\Webtrees\I18N; +use Fisharebest\Webtrees\Individual; use Illuminate\Support\Collection; /** - * @var int $limit_high - * @var int $limit_low - * @var Collection $yahrzeits + * @var int $limit_high + * @var int $limit_low + * @var Collection $yahrzeits */ ?> @@ -49,13 +52,13 @@ use Illuminate\Support\Collection; - + fact_date->display($yahrzeit->individual->tree()) ?> - + fact->anniv) ?> - + yahrzeit_date->display($yahrzeit->individual->tree()) ?>