Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue(?): Modrinth upload debug output does not list files. #23

Open
iChun opened this issue Jun 12, 2024 · 2 comments
Open

Issue(?): Modrinth upload debug output does not list files. #23

iChun opened this issue Jun 12, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@iChun
Copy link

iChun commented Jun 12, 2024

Doing a debug upload to Modrinth doesn't list the files uploaded unlike its CurseForge counterpart

Output:

Scanning <JARFILE> for presence of fractureiser
Full data to be sent for upload: {
  "name": "[1.20.6 NeoForge] v 1.0.0",
  "versionNumber": "1.0.0",
  "changelog": <STRIPPED>,
  "dependencies": [],
  "gameVersions": [
    "1.20.6"
  ],
  "versionType": "release",
  "loaders": [
    "neoforge"
  ],
  "featured": false,
  "projectId": <STRIPPED>
}

I wasn't sure if this was intentional or not, I was testing the new addAdditionalFiles from #5 (comment) and wanted to test that the additional files are still uploaded to Modrinth as the documentation isn't clear on this (it says it's only supported on CF). I've seen from the code that it is, but wanted to double check.

@hypherionmc
Copy link
Member

hypherionmc commented Jun 12, 2024

I don't even remember adding the additional files to modrinth 😅

I actually saw this as well. What's strange, is we use the same method as Minotaur (modrinths plugin) to print the debug output, so it is very strange that the files are not included.

project.getLogger().lifecycle("Full data to be sent for upload: {}", gson.toJson(builder.build()));

Will have to see if I missed something somewhere.

Side Note: I see my comment on the addAdditionalFiles is misleading. The changelog and display name override is only supported on CurseForge (as far as I know, modrinth doesn't support this).

@iChun
Copy link
Author

iChun commented Jun 12, 2024

It could be entirely possible that Minotaur also doesn't print out the files on debug, have not used them before.

Thanks for looking into this though!

@hypherionmc hypherionmc added the enhancement New feature or request label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants