-
-
Notifications
You must be signed in to change notification settings - Fork 81.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The "Submit your changes for review" step sometimes doesn't work as intended #82666
Comments
can i work on it |
@Horusateel you need to push. Have you done |
@williamalvarezdev
On the contrary, Here's a list of the last four commands before it actually worked and the button indeed appeared for me to complete the guide:
PS: I was testing whether it has something to do with the nature of the commit, since I didn't include a github account link in the alonzo-church trial, but I didn't include a link in the Horusateel-Horusateel trial neither and it worked just fine. |
Maybe you are missing the .git file. Maybe a simple, delete the file and clone it again might work. The commands you wrote there seems fine. |
Just tried this out, and the same issue persisted. Don't know how to test whether the .git file exists or not though, how can I test that? |
Do you get any error messages? |
@williamalvarezdev |
I use visual studio code. They have a feature where you can compare. Otherwise some plugins with vim also works ok |
Have you tried doing git push -u origin add-alonzo-church ? |
When getting to this step, sometimes I indeed found the "Compare & pull request" button as intended, others I didn't.
🐞 Problem
When applying the exact commands mentioned in the tutorial:
git switch -c add-alonzo-church
for creating a branch andgit commit -m "add alonzo church to Contributors list"
for committing, the needed button "Compare & pull request" doesn't appear however many times I refreshed the page.🎯 Goal
Refine the instructions so the button appears despite whatever the name of the branch or the commit message provided with it.
💡 Possible solutions
I suspect the problem has to do with some keywords in the commit message or the branch name, if absent the button doesn't appear at all.
📋 Steps to solve the problem
Perhaps a sequence of trials with various names, branches' names and commit messages to pinpoint the exact words that trigger the button?
I have tried to apply this approach but lost count in the middle.
The text was updated successfully, but these errors were encountered: