Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't work with FF49 #39

Open
sdavidg opened this issue Sep 22, 2016 · 2 comments
Open

Don't work with FF49 #39

sdavidg opened this issue Sep 22, 2016 · 2 comments

Comments

@sdavidg
Copy link

sdavidg commented Sep 22, 2016

"Handler function threw an exception: TypeError: this.tooltip is undefined
Stack: DataTooltip.prototype.show<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://firequery-at-binaryage-dot-com/lib/data-tooltip.js:68:5
exports.makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:101:14
InspectorOverlay<.onClickTooltip/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://firequery-at-binaryage-dot-com/lib/inspector-overlay.js:255:7
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:750:11
Line: 68, column: 5"

@janodvarko
Copy link
Member

This bug is probably the culprit:
https://bugzilla.mozilla.org/show_bug.cgi?id=1267414

Honza

@janodvarko
Copy link
Member

So, the right way to go here is probably create new Tooltip instance and not touch internals of the MarkupView, which can change.

Note:
Render tooltip content using React component
https://bugzilla.mozilla.org/show_bug.cgi?id=1306291

Honza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants