From 4ff947408728ce4ae20229d7eb0cd71c3e65c885 Mon Sep 17 00:00:00 2001 From: Christina Holland Date: Fri, 23 Aug 2024 13:05:18 -0700 Subject: [PATCH] Fix AppCheck getToken docs text (#8454) --- docs-devsite/app-check.md | 4 ++-- packages/app-check/src/api.ts | 8 +++++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/docs-devsite/app-check.md b/docs-devsite/app-check.md index 0673cf0373b..ea60678e688 100644 --- a/docs-devsite/app-check.md +++ b/docs-devsite/app-check.md @@ -22,7 +22,7 @@ Firebase App Check does not work in a Node.js environment using `ReCaptchaV3Prov | [initializeAppCheck(app, options)](./app-check.md#initializeappcheck_5548dfc) | Activate App Check for the given app. Can be called only once per app. | | function(appCheckInstance, ...) | | [getLimitedUseToken(appCheckInstance)](./app-check.md#getlimitedusetoken_53ef5e3) | Requests a Firebase App Check token. This method should be used only if you need to authorize requests to a non-Firebase backend.Returns limited-use tokens that are intended for use with your non-Firebase backend endpoints that are protected with Replay Protection. This method does not affect the token generation behavior of the \#getAppCheckToken() method. | -| [getToken(appCheckInstance, forceRefresh)](./app-check.md#gettoken_39fc1b3) | Get the current App Check token. Attaches to the most recent in-flight request if one is present. Returns null if no token is present and no token requests are in-flight. | +| [getToken(appCheckInstance, forceRefresh)](./app-check.md#gettoken_39fc1b3) | Get the current App Check token. If forceRefresh is false, this function first checks for a valid token in memory, then local persistence (IndexedDB). If not found, or if forceRefresh is true, it makes a request to the App Check endpoint for a fresh token. That request attaches to the most recent in-flight request if one is present. | | [onTokenChanged(appCheckInstance, observer)](./app-check.md#ontokenchanged_9761e16) | Registers a listener to changes in the token state. There can be more than one listener registered at the same time for one or more App Check instances. The listeners call back on the UI thread whenever the current token associated with this App Check instance changes. | | [onTokenChanged(appCheckInstance, onNext, onError, onCompletion)](./app-check.md#ontokenchanged_8ef80a7) | Registers a listener to changes in the token state. There can be more than one listener registered at the same time for one or more App Check instances. The listeners call back on the UI thread whenever the current token associated with this App Check instance changes. | | [setTokenAutoRefreshEnabled(appCheckInstance, isTokenAutoRefreshEnabled)](./app-check.md#settokenautorefreshenabled_057a76c) | Set whether App Check will automatically refresh tokens as needed. | @@ -102,7 +102,7 @@ The limited use token. ### getToken(appCheckInstance, forceRefresh) {:#gettoken_39fc1b3} -Get the current App Check token. Attaches to the most recent in-flight request if one is present. Returns null if no token is present and no token requests are in-flight. +Get the current App Check token. If `forceRefresh` is false, this function first checks for a valid token in memory, then local persistence (IndexedDB). If not found, or if `forceRefresh` is true, it makes a request to the App Check endpoint for a fresh token. That request attaches to the most recent in-flight request if one is present. Signature: diff --git a/packages/app-check/src/api.ts b/packages/app-check/src/api.ts index cd0c7de2d74..e6897320be1 100644 --- a/packages/app-check/src/api.ts +++ b/packages/app-check/src/api.ts @@ -187,9 +187,11 @@ export function setTokenAutoRefreshEnabled( state.isTokenAutoRefreshEnabled = isTokenAutoRefreshEnabled; } /** - * Get the current App Check token. Attaches to the most recent - * in-flight request if one is present. Returns null if no token - * is present and no token requests are in-flight. + * Get the current App Check token. If `forceRefresh` is false, this function first + * checks for a valid token in memory, then local persistence (IndexedDB). + * If not found, or if `forceRefresh` is true, it makes a request to the + * App Check endpoint for a fresh token. That request attaches + * to the most recent in-flight request if one is present. * * @param appCheckInstance - The App Check service instance. * @param forceRefresh - If true, will always try to fetch a fresh token.