Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Filter by tag #26

Open
pmonks opened this issue May 10, 2018 · 3 comments
Open

Filter by tag #26

pmonks opened this issue May 10, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@pmonks
Copy link
Contributor

pmonks commented May 10, 2018

Need to add a filter by tag. This should be a multi-select (same as the other filters).

@pmonks pmonks added the enhancement New feature or request label May 10, 2018
@maoo
Copy link
Member

maoo commented May 13, 2018

Done! Here's a preview - https://rawgit.com/finos/finos.github.io/tags/index.html ; @pmonks - please let me know if there are some functional fixes to apply.

@nikoganev - can you please check why the tag spans don't go to a new line? Tried to play with word-wrap (see https://stackoverflow.com/questions/17462741/don-t-wrap-span-elements) but no luck.

@pmonks
Copy link
Contributor Author

pmonks commented May 14, 2018

Couple of comments:

  • the font used for tags in each card should be smaller (though I like the bold)
  • tags should definitely wrap (cc @nikoganev)
  • the tags on each card should be clickable, and when clicked should act the same as if that tag was selected in the "tags" filter on the left (note: this would "add-on" the clicked tag to any existing tag filters the user had already selected)

@pmonks
Copy link
Contributor Author

pmonks commented May 14, 2018

Also, the yellow background on the tags needs to be removed - it looks like a bug:

screen shot 2018-05-14 at 11 08 22 am

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants