Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ReceiveMessage error handling #421

Closed
Stebalien opened this issue Jul 7, 2024 · 0 comments · Fixed by #442
Closed

Improve ReceiveMessage error handling #421

Stebalien opened this issue Jul 7, 2024 · 0 comments · Fixed by #442
Assignees
@Stebalien
Milestone
Milestone 0: F3 A...

Comments

@Stebalien
Copy link
Member

Right now, ReceiveMessage returns both "fatal" errors (e.g., panics) and non-fatal errors (messages from the wrong instance). We should log non-errors internally and only return "real" errors.

This hasn't been an issue in testing because we're not using real pubsub with proper async message delivery. But it will be on mainnet.
@Stebalien Stebalien mentioned this issue Jul 7, 2024
Merged
@Stebalien Stebalien self-assigned this Jul 7, 2024
Stebalien added a commit that referenced this issue Jul 10, 2024
@Stebalien
Skip messages from the wrong instance instead of returning an error
eae7f8e 
Due to async message delivery, we'll frequently get messages from the
wrong instance. Log (trace) and drop them.

Part of #421.
@Stebalien Stebalien mentioned this issue Jul 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 11, 2024
@Stebalien
Skip messages from the wrong instance instead of returning an error (#…
d0f5a05 
…442)

* Skip messages from the wrong instance instead of returning an error

Due to async message delivery, we'll frequently get messages from the
wrong instance. Log (trace) and drop them.

Part of #421.

* fix test
@Kubuxu Kubuxu linked a pull request Jul 13, 2024 that will close this issue
Skip messages from the wrong instance instead of returning an error #442
Merged
@Kubuxu Kubuxu closed this as completed Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
Milestone 0: F3 Alpha Code Freeze
Development

Successfully merging a pull request may close this issue.

Skip messages from the wrong instance instead of returning an error filecoin-project/go-f3
2 participants
@Stebalien @Kubuxu