Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong limits of 2D intensity histogram for float or 16-bit input images #71

Open
bene51 opened this issue Sep 11, 2020 · 3 comments
Open

Comments

@bene51
Copy link

bene51 commented Sep 11, 2020

Hi,

you can reproduce my issue by creating two new (identical) images of type float, then run Coloc 2 on them.

What I'd expect is a diagonal line (since it's two identical images), and I do get a line indeed, but it's not diagonal (see screenshot below).

When I move the cursor over the 2D histogram, it shows me x/y values from 0 to 255, but the intensities in the input images (being floats) are [0;1], not sure if this is related...

2D_Histogram

Best wishes,
Bene

@haesleinhuepf
Copy link

Hey @bene51 ,

thanks for reporting! Even more suspicious: I just attempted to reproduce your issue with blobs.gif (8-bit, twice):

image

These were my settings:
image

With 16-bit blobs it looks like this btw:
image

Let's ping @etadobson and @chalkie666 and see if thay can give us some pointers or hints :-)

Cheers,
Robert

@chalkie666
Copy link
Collaborator

Hi folks @bene51 @haesleinhuepf I do remember that if you put 2 identical images as input the maths explodes for some reason that is documented in the code as far as I remember. It's a divide by zero or something like that. Try adding a tiny bit of noise to one if the input images . Maybe it's a bug though...

@imagejan
Copy link
Member

imagejan commented Oct 1, 2020

@chalkie666 wrote:

the maths explodes for some reason that is documented in the code as far as I remember.

I couldn't find any comment in the source code, but found this note on the wiki page https://github.com/fiji/Colocalisation_Analysis/wiki/DesignNotes:

Test if images are actually identical - warn user (cause numerical problem div 0 in Pearson/Manders?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants