Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PinRetry less than 8 not supported by the test suit #771

Open
3 of 17 tasks
carov0610 opened this issue Oct 29, 2024 · 1 comment
Open
3 of 17 tasks

PinRetry less than 8 not supported by the test suit #771

carov0610 opened this issue Oct 29, 2024 · 1 comment
Assignees
Labels
DONE Has been implemented as part of one of the published releases

Comments

@carov0610
Copy link

carov0610 commented Oct 29, 2024

By submitting this issue you are acknowledging that any information regarding this issue will be publicly available.

If you have privacy concerns, please email [email protected]

FIRST PRE CHECK

  • I SOLEMNLY SWEAR THAT I HAVE SEARCHED DOCUMENTATION AND WAS NOT ABLE TO RESOLVE MY ISSUE

What protocol are you implementing?

  • FIDO2 Server
  • CTAP2.0
  • CTAP2.1
  • UAF 1.1
  • U2F 1.1
  • U2F 1.2

NOTE: UAF 1.0 certification have been officially sunset. U2F 1.2 only supported version of U2F.

What is your implementation class?

  • Security Key / FIDO2 / U2F authenticators
  • Server
  • UAF Client-ASM-Authenticator combo
  • UAF Client
  • UAF ASM-Authenticator

If you are platform authenticator vendor, please email [email protected]

What is the version of the tool are you using?

1.7.21.7

What is the OS and the version are you running?

Windows10

For desktop tools

  • OSX
  • Windows
  • Linux

For UAF mobile tools

  • iOS
  • Android

Issue description

When running the FIDO Alliance Conformance tool with an authenticator on which the max pin retry number is less than the max defined by the CTAP 2.1 specification (for example 3) the test in Authr-ClientPin1-GetRetries Test authenticatorClientPin(0x06), of version 0x01 support of getRetries(0x01) command fails
It is said that "
P-1 Send a valid CTAP2 authenticatorClientPin(0x01) message with getRetries(0x01) subCommand, wait for the response, and check that Authenticator returns CTAP1_ERR_SUCCESS(0x00) error code, and:
(a) check that authenticatorClientPin_Response contains "retries" field
(b) authenticatorClientPin_Response.retries is of type NUMBER
(c) authenticatorClientPin_Response.retries is extractly 8‣
"
(c) checks that the number of retries is 8 and this number is hard-coded in the test whereas CTAP2.1 specification says
Authenticators MUST allow no more than 8 retries but MAY set a lower maximum.

@iirachek iirachek self-assigned this Nov 4, 2024
@iirachek iirachek added the Awaiting Release Is ready and is awaiting merge for the next release label Nov 6, 2024
@iirachek
Copy link

The issue should be fixed in the latest v1.7.22

@iirachek iirachek added DONE Has been implemented as part of one of the published releases and removed Awaiting Release Is ready and is awaiting merge for the next release labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DONE Has been implemented as part of one of the published releases
Projects
None yet
Development

No branches or pull requests

2 participants