Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename task.failed to task.fail #53

Open
RcubDev opened this issue Sep 4, 2021 · 1 comment
Open

rename task.failed to task.fail #53

RcubDev opened this issue Sep 4, 2021 · 1 comment

Comments

@RcubDev
Copy link
Contributor

RcubDev commented Sep 4, 2021 •
edited
Loading

Hi! Thank you for this awesome plugin! This is a small recommendation of renaming task.failed to task.fail. The tenses of these verbs are not consistent. The past tense of fail is failed. The past tense of succeed is succeeded. If you like the proposal and would like me to make a PR I would be happy to!
@RcubDev RcubDev changed the title task.succeed and task.failed rename task.failed to task.fail Sep 4, 2021
@fian46
Copy link
Owner

fian46 commented Sep 9, 2021

Yes we can add new fail but keep failed too so it won't break people project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RcubDev @fian46