Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support modifier key to send mouse events to/through xterm.js, not terminal app #84

Open
Riebart opened this issue Sep 28, 2018 · 4 comments
Labels
upstream This due to an external component we are using

Comments

@Riebart
Copy link
Contributor

Riebart commented Sep 28, 2018

It'd be nice to be able to send mouse events to the process, not the terminal. Selecting tmux panes, scrolling in less, etc... These work in the Windows consoles, so there should be a way to make them work for us too.

I'll note that this doesn't even work in the VSCode terminal, which is my benchmark for xterm.js based terminals on Windows, so... This will likely have to wait until 1809 drops.

Based on some poking around for other reasons, this would likely involve some modifications around here:

void OnMouseClick(MouseButton mouseButton, int x, int y, bool hasSelection);

@felixse
Copy link
Owner

felixse commented Sep 28, 2018

There is not much we can do on our side right now, we are waiting for xtermjs/xterm.js#1536

@felixse felixse added the upstream This due to an external component we are using label Sep 28, 2018
mjs pushed a commit to mjs/FluentTerminal that referenced this issue May 14, 2019
Fixing a bug with incomplete links, and making username field bigger

It's so trivial that I'll merge without waiting for tests.
@jackluo923
Copy link

Are there any plan to fix this issue now that xterm.js supports sending mouse events through?
As @mjs suggests, visual studio code terminal is benchmark for xterm.js on Windows and the support is enabled there now, we should integrate this feature in.

@cjw296
Copy link

cjw296 commented Dec 4, 2019

I'd prefer a setting per profile rather than a modifier key, but maybe I'm missing something?

@VolanDeVovan
Copy link

Any progress on this issue?
This is a very important function for using the terminal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream This due to an external component we are using
Projects
None yet
Development

No branches or pull requests

5 participants