Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy multiline text may fail for some lines #169

Open
thochra opened this issue Jan 8, 2019 · 1 comment
Open

Copy multiline text may fail for some lines #169

thochra opened this issue Jan 8, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@thochra
Copy link

thochra commented Jan 8, 2019

Hello.

Context: Wsl / ssh to remote linux and tailed some logs

When the displayed line in the terminal ends with a conventional character the copy works well.
But, if the line ends with a space character then the log line is splitted.
Check the red square on the next picture and compare with the result pasted in vscode.

image

As we can see with the previous log line, if the displayed line starts with a space, the complete log line is kept.

I noticed they handled it in vscode's terminal which is also using xterm.

Could it be possible the simple use of their version of xterm would solve the issue?
https://github.com/Microsoft/vscode/blob/1.30.2/package.json
https://www.npmjs.com/package/vscode-xterm

In the meantime I wonder if vscode-xterm is not too far from xterm, because I did cross read this post https://codeburst.io/source-reading-how-is-new-terminal-in-vs-code-so-fast-10a40f7f8792.

Aside that, nice work! Looks promising 👍

@felixse felixse added the bug Something isn't working label Jan 18, 2019
@thochra
Copy link
Author

thochra commented May 20, 2019

Hello, I tested again with version 0.4.1.0.
The line break issue seems to be gone 👍

But unfortunately there is now a little glitch with the copied string:
Annotation 2019-05-20 102349

EDIT: Forgot to mention that I used win 10 1809 with always use WinPty option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants