Retry publishing for all connection-related errors #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously publishing was only retried if the connection was closed cleanly. However, it might close for other reasons (someone trips over a cord, a firewall kills a connection, etc). We should go through the retry process for any connection exception. Fixes fedora-infra#175 Signed-off-by: Jeremy Cline <[email protected]>
bowlofeggs
reviewed
May 17, 2019
| @@ -153,7 +153,7 @@ def publish(self, message, exchange=None): | |||
| except (pika_errs.NackError, pika_errs.UnroutableError) as e: | |||
| _log.warning("Message was rejected by the broker (%s)", str(e)) | |||
| raise PublishReturned(reason=e) | |||
| except (pika_errs.ConnectionClosed, pika_errs.AMQPChannelError): | |||
There was a problem hiding this comment.
Why do we want to stop handling ConnectionClosed here?
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
=======================================
Coverage 95.53% 95.53%
=======================================
Files 14 14
Lines 1478 1478
Branches 198 198
=======================================
Hits 1412 1412
Misses 50 50
Partials 16 16
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously publishing was only retried if the connection was closed
cleanly. However, it might close for other reasons (someone trips over a
cord, a firewall kills a connection, etc). We should go through the
retry process for any connection exception.
Fixes #175
Signed-off-by: Jeremy Cline [email protected]