[Potential Bug] - when executing a PATCH with an empty body a 500 Error is thrown, i'd expect a 400 Bad Request

[i-terzic]

Hello, i'm not sure whether this is a bug or configuration problem. When validating an API the following issue occured: I performed a PATCH request with curl.

curl -X PATCH -H 'Authorization: [Filtered]' -H 'Content-Type: application/json' -d '[]' http://localhost:3030/projects/0

The response is the following:

{"message":"Empty .update() call detected! Update data does not contain any values to update. This will result in a faulty query. Table: projects. Columns: ."}

Although i would expect a 400 Bad Request, since a PATCH with an empty body doesn't make any sense and should not throw an error. Or am I missing something?

The relevant configuration is the following:

app.use(bodyParser({ jsonStrict: false })); // in app.ts

// in projects.class.ts
export const getOptions = (app: Application): KnexAdapterOptions => {
  return {
    paginate: app.get('paginate'),
    Model: app.get('dbClient'),
    name: 'projects'
  }
}

[i-terzic]

Bug in our own code. 🫨