-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript: Hook type no longer compatible for disablePagination #564
Comments
lwhiteley
changed the title
Hook types are no longer compatible
Hook type no longer compatible for disablePagination ... (maybe some others)
Jan 19, 2020
lwhiteley
changed the title
Hook type no longer compatible for disablePagination ... (maybe some others)
Hook type no longer compatible for disablePagination
Jan 19, 2020
lwhiteley
changed the title
Hook type no longer compatible for disablePagination
Typescript: Hook type no longer compatible for disablePagination
Jan 19, 2020
Having the same issue with
Also using
As a workaround for now I'm doing the following: {
after: {
all: [],
find: [(validateSchema(responseSchema(), ajv) as unknown) as Hook],
get: [],
create: [],
update: [],
patch: [],
remove: [],
},
} |
@eXigentCoder it works! But hope for fixing. |
did you get the solution??? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
Using disablePagination hook produces a typescript error
eg. 1
eg 2
Actual behavior
Application does not compile when hook is used
Expected behavior
Application should compile without issues
Module versions :
"@feathersjs/feathers": "^4.5.0",
"feathers-hooks-common": "^5.0.1",
"tslint": "^5.20.1",
"typescript": "^3.7.5"
If it helps.
im using yarn as the package manager
The text was updated successfully, but these errors were encountered: