Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastlane, main doc beta & release lanes #825

Open
GioLogist opened this issue May 2, 2019 · 2 comments
Open

Fastlane, main doc beta & release lanes #825

GioLogist opened this issue May 2, 2019 · 2 comments

Comments

@GioLogist
Copy link

In the main docs page, the following 2 lanes are defined:

lane :beta do
  increment_build_number
  build_app
  upload_to_testflight
end

lane :release do
  capture_screenshots
  build_app
  upload_to_app_store       # Upload the screenshots and the binary to iTunes
  slack                     # Let your team-mates know the new version is live
end

Is there a reason the release lane isn't including increment_build_number?

If a dev currently uses the following workflow:

  1. Deploys beta
  2. Tests
  3. Deploys release

With the current script, they'll run into an issue where there is already an existing app with the same build # & version #. I suggest we add increment_build_number to the release lane, so as not to confuse devs into thinking that its handled automagically via release lanes somehow.

@GioLogist GioLogist changed the title Fastlane, main docs Fastlane, main doc beta & release lanes May 2, 2019
@janpio
Copy link
Member

janpio commented May 3, 2019

I think that is a valid point. Or are there common scenarios where this would not be needed? Does this maybe assume the user does this manually?

I guess it is this way to not overcomplicate things, but if this results in broken uploads for users this of course doesn't help.

@GioLogist
Copy link
Author

Yea, exactly. It'll definitely result in broken uploads.

With the workflow, we have two options:

  1. Log into App Store connect and submit the same build currently on TestFlight
  2. Use fastlane, but with an incremented build number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants