Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some container versions in Docker #1318

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Update some container versions in Docker #1318

wants to merge 22 commits into from
+3 −3

Conversation

javadzarezadeh
Copy link

@javadzarezadeh javadzarezadeh commented Aug 27, 2024 •
edited
Loading

Change Postgres, Node, Traefik, and uvicorn-gunicorn-fastapi version tags to a more recent one. Changed branch name for my development consistency.

edit: Since uvicorn-gunicorn-fastapi is not a part of the project anymore, I changed the python version to the latest Python 3 instead of uvicorn-gunicorn-fastapi.

@javadzarezadeh
Copy link
Author

Dear @alejsdev,
I'm really sorry that I changed the branch name. May you please label this PR, so that the checks become successful?

@svlandeg svlandeg mentioned this pull request Sep 2, 2024
Merged
tiangolo
tiangolo requested changes Sep 30, 2024
View reviewed changes
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I would prefer to use version numbers, I added some comments inline. 🤓

backend/Dockerfile Outdated Show resolved Hide resolved
docker-compose.override.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated
@@ -1,7 +1,7 @@
services:

db:
image: postgres:12
image: postgres:16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🚀

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that Postgres has officially released version 17 four days ago. Should I stick to 16 or upgrade it to 17?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you were working on more importatn tasks (perfect SQLModel Documentation, by the way!😉), I changed it to 17 without your permission! Sorry for that. If you still wish to use 16, just tell me to change it.

frontend/Dockerfile Outdated Show resolved Hide resolved
@javadzarezadeh
Copy link
Author

Thanks! I would prefer to use version numbers, I added some comments inline. 🤓

Sure Sir! 🫡 I'll push your requests in a couple of minutes.

@github-actions github-actions bot removed the waiting label Sep 30, 2024
@javadzarezadeh
Copy link
Author

‼️IMPORTANT‼️
@tiangolo @alejsdev
PostgreSQL 12 is now EOL and will not receive updates anymore. I highly recommend speeding up the PR procedure if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiangolo tiangolo Awaiting requested review from tiangolo

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javadzarezadeh @tiangolo @alejsdev