Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support receive Promise plugin #1224

Open
shulandmimi opened this issue Apr 21, 2024 · 5 comments · May be fixed by #1274
Open

support receive Promise plugin #1224

shulandmimi opened this issue Apr 21, 2024 · 5 comments · May be fixed by #1274
Labels
pr welcome Welcome contributions for newcomers

Comments

@shulandmimi
Copy link
Member

What problem does this feature solve?

// farm.config.ts
const loadAsyncJsPlugin = async () => ({ ... });
const loadAsyncArrJsPlugin = async () => [{ ... }, { ... }]
const loadAsyncRustPlugin async () => '@farmfe/rust-plugin';
const loadAsyncArrRustPlugin async () => [['@farmfe/rust-plugin', options], ...];

export default {
	plugins: [loadAsyncJsPlugin(), loadAsyncArrJsPlugin(), loadAsyncRustPlugin(), loadAsyncArrRustPlugin()]
}

What does the proposed API look like?

modify

combine these two function
@shulandmimi shulandmimi added the pr welcome Welcome contributions for newcomers label Apr 21, 2024
@DeepeshKalura DeepeshKalura mentioned this issue Apr 27, 2024
Closed
@DeepeshKalura
Copy link

@shulandmimi I raised the PR tyres to resolve your issue could please look at it and let me know any improvements needed

#1255

@shulandmimi
Copy link
Member Author

@DeepeshKalura Thank you very much for your PR, but I see it has not been updated recently, do you have the energy to achieve the rest of it? I can assign this issue to you if you like.

@DeepeshKalura
Copy link

@shulandmimi Yeah I would love to work in this issue. The reason I not been updating recently because I was getting a bug while working on this issue Error: Cannot find module '019171a2' while running with pnpm bootstrap. Debugging this issue cause lot's of time.

I got a suggestion to re-clone the project and restart the work from discord farm community. Working on that part.

This was referenced Apr 30, 2024
Closed
Open
@ErKeLost
Copy link
Member

Has the problem been solved? I didn't reproduce the mistakes you found locally.

@DeepeshKalura
Copy link

@ErKeLost Even I can't reproduce later. I just delete the entire code and re-clone it. So, I think problem has been solved for good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pr welcome Welcome contributions for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@shulandmimi @ErKeLost @DeepeshKalura