Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timelocks and fee strategy in reveal protocol messages #88

Open
h4sh3d opened this issue Apr 16, 2021 · 1 comment
Open

Add timelocks and fee strategy in reveal protocol messages #88

h4sh3d opened this issue Apr 16, 2021 · 1 comment

Comments

@h4sh3d
Copy link
Member

h4sh3d commented Apr 16, 2021

Instead of adding a new round of communication as proposed in #48 we can add in the reveal message:

  • cancel timelock
  • punish timelock; and
  • fee strategy

these parameters are derived form the local public offer, thus if a mismatch is found we can early quit the swap process.

@h4sh3d
Copy link
Member Author

h4sh3d commented Apr 16, 2021

It is worth noting that if a mismatch is present, and incompatible (mismatch can be compatible with the fee strategy e.g.), it will be catch anyway downstream by the validations, thus this may force going on-chain to cancel the swap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant