We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We currently use verifyFakes to test the combinators like this:
verifyFakes
verifyFakes :: [Fake Text] -> IO [Bool] verifyFakes funs = do let fs :: [IO Text] = map (generateWithSettings fakerSettings) funs gs :: [IO Bool] = map (\f -> isText <$> f) fs sequence gs
Instead, we should be using quickcheck to generate the dataset. We already have quickcheck as the test dependency, so it shouldn't be an issue. Also, checking for non null property and different samples should be good enough. Example for non null property: https://hackage.haskell.org/package/fakedata-quickcheck-0.2.0/docs/Test-QuickCheck-Gen-Faker.html
Example for different samples: https://github.com/fakedata-haskell/fakedata-quickcheck/blob/e6d10ad99796665d8041dbbbd3764407b14116f5/test/Test/FakeQuickCheckSpec.hs#L32
The text was updated successfully, but these errors were encountered:
No branches or pull requests
We currently use
verifyFakes
to test the combinators like this:Instead, we should be using quickcheck to generate the dataset. We already have quickcheck as the test dependency, so it shouldn't be an issue. Also, checking for non null property and different samples should be good enough. Example for non null property: https://hackage.haskell.org/package/fakedata-quickcheck-0.2.0/docs/Test-QuickCheck-Gen-Faker.html
Example for different samples: https://github.com/fakedata-haskell/fakedata-quickcheck/blob/e6d10ad99796665d8041dbbbd3764407b14116f5/test/Test/FakeQuickCheckSpec.hs#L32
The text was updated successfully, but these errors were encountered: