Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub API rate limiting #93

Closed
sverhoeven opened this issue Jan 25, 2021 · 4 comments · Fixed by #321
Closed

GitHub API rate limiting #93

sverhoeven opened this issue Jan 25, 2021 · 4 comments · Fixed by #321
Assignees
@jspaaks
Milestone
0.14.0

Comments

@sverhoeven
Copy link
Member

The GitHub API is used anonymously in this library. If used more than 60 req per hour the API will say no. This limit could be reached when asserting a bunch of software like on https://www.research-software.nl/ .

One way to solve is to use an OAuth token which will up the limit to 5000 req per hour. It would be nice if the howfairis tool would allow passing a GitHub OAuth token either as environment variable or as command line argument.

GitLab also has rate limit, but is much higher so not such a problem.
@jspaaks
Copy link
Member

jspaaks commented Jan 26, 2021

Agreed, this is something we should fix. It has already been a problem: fair-software/howfairis-github-action#36

@sverhoeven
Copy link
Member Author

When recordings are used in tests we should filter the token out of the recording so they don't leak. See https://vcrpy.readthedocs.io/en/latest/advanced.html#filter-sensitive-data-from-the-request

@jspaaks jspaaks mentioned this issue Feb 12, 2021
Merged
@jspaaks
Copy link
Member

jspaaks commented Feb 19, 2021

Issue was auto-closed by fix keyword, reopening

@jspaaks jspaaks reopened this Feb 19, 2021
jspaaks added a commit that referenced this issue Feb 20, 2021
@jspaaks
added ratelimited functions with exponential backoff and retry; refs #93
ca27c2c
jspaaks added a commit that referenced this issue Feb 20, 2021
@jspaaks
added backoff and ratelimit dependencies; refs #93; changed the semve…
f3b6774 
…r range notaion to a less ambiguous style
@jspaaks jspaaks mentioned this issue Feb 20, 2021
Merged
@jspaaks jspaaks self-assigned this Feb 21, 2021
@jspaaks jspaaks added this to the 0.14.0 milestone Feb 24, 2021
@jspaaks
Copy link
Member

jspaaks commented Feb 25, 2021

PR was merged, closing

@jspaaks jspaaks closed this as completed Feb 25, 2021
sverhoeven added a commit that referenced this issue Mar 9, 2021
@sverhoeven
Describe why apikey is needed, where to get them and the format.
d404d5a 
Fixes #319
Fixes #93 completely
@sverhoeven sverhoeven mentioned this issue Mar 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jspaaks jspaaks

Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

Describe why apikey is needed, where to get them and the format. fair-software/howfairis
2 participants
@sverhoeven @jspaaks